Pass relative path to HTTP adapters #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@z38 Thank you for your contribution! I'll take a deeper look on this prior to merge it, also I'd like to check if this should be included in 2.0 as well. |
yukoff
suggested changes
Sep 7, 2017
| $this->request = $request; | ||
|
|
||
| return [ | ||
| 'base_uri' => $request->getOptions()->get('base_url'), |
There was a problem hiding this comment.
I guess base_uri here is a typo?
There was a problem hiding this comment.
It's actually the correct name (I remember re-reading the docs because it looked unusual to me too ;) )
There was a problem hiding this comment.
I see, just ran into the same confusion ;) Thanks for the follow-up. I'd like to check if this could be covered with test prior merging.
yukoff
approved these changes
Sep 7, 2017
|
Thank you for your contribution, @z38! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch restores the way paths are stored in
Tmdb\HttpClient\Request. The base URL is no longer part of the path and is passed to the HTTP adapter as part of the options bag (fixes #145).Note: Custom HTTP adapters which do not follow the documented practice will probably break after applying this change.